mgr/dashboard: Fix RGW bucket edit issue

Commit f21d0da introduced an error in
bucket edit action.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1647154
RHCS: 3.2
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Author: epuertat

src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-form/rgw-bucket-form.component.ts

@@ -51,11 +51,11 @@ export class RgwBucketFormComponent implements OnInit {
         if (!params.hasOwnProperty('bucket')) {
           return;
         }
-        params.bucket = decodeURIComponent(params.bucket);
+        const bucket = decodeURIComponent(params.bucket);
         this.loading = true;
         // Load the bucket data in 'edit' mode.
         this.editing = true;
-        this.rgwBucketService.get(params.bucket).subscribe((resp: object) => {
+        this.rgwBucketService.get(bucket).subscribe((resp: object) => {
           this.loading = false;
           // Get the default values.
           const defaults = _.clone(this.bucketForm.value);

src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.ts

@@ -47,7 +47,7 @@ export class RgwBucketListComponent {
       }
     ];
     const getBucketUri = () =>
-      this.selection.first() && `${encodeURI(this.selection.first().bucket)}`;
+      this.selection.first() && `${encodeURIComponent(this.selection.first().bucket)}`;
     const addAction: CdTableAction = {
       permission: 'create',
       icon: 'fa-plus',

src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.ts

@@ -154,13 +154,14 @@ export class RgwUserFormComponent implements OnInit {
       if (!params.hasOwnProperty('uid')) {
         return;
       }
+      const uid = decodeURIComponent(params.uid);
       this.loading = true;
       // Load the user data in 'edit' mode.
       this.editing = true;
       // Load the user and quota information.
       const observables = [];
-      observables.push(this.rgwUserService.get(params.uid));
-      observables.push(this.rgwUserService.getQuota(params.uid));
+      observables.push(this.rgwUserService.get(uid));
+      observables.push(this.rgwUserService.getQuota(uid));
       observableForkJoin(observables).subscribe(
         (resp: any[]) => {
           this.loading = false;

src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-list/rgw-user-list.component.ts

@@ -63,7 +63,8 @@ export class RgwUserListComponent {
         flexGrow: 1
       }
     ];
-    const getUserUri = () => this.selection.first() && this.selection.first().user_id;
+    const getUserUri = () =>
+      this.selection.first() && `${encodeURIComponent(this.selection.first().user_id)}`;
     const addAction: CdTableAction = {
       permission: 'create',
       icon: 'fa-plus',