Skip to content

fixed 24hr booking bug#806

Merged
kwangyy merged 1 commit into
mainfrom
debug-24hr
Sep 20, 2023
Merged

fixed 24hr booking bug#806
kwangyy merged 1 commit into
mainfrom
debug-24hr

Conversation

@LWS49

@LWS49 LWS49 commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Resolves: Booking Bug where 24-hour bookings in the same day are not shown in RH-App

Changed const endHour = endTimeObject.getHours() < startHour to const endHour = endTimeObject.getHours() <= startHour so that for 00:00 to 00:00, end hour is at 24 instead of 0.

  • [ x] I made sure the code compiles on my machine
  • [ x] I made sure there are no unnecessary changes in** the code
  • [x ] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"

@vercel

vercel Bot commented Sep 19, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rhapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 1:53am

@LWS49 LWS49 requested a review from kwangyy September 19, 2023 22:56

@kwangyy kwangyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwangyy kwangyy merged commit 295ab0e into main Sep 20, 2023
@kwangyy kwangyy deleted the debug-24hr branch September 20, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants