This repository was archived by the owner on Apr 8, 2024. It is now read-only.
Merged
Conversation
adrian-gierakowski
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow the Portal to migrate to Vite, we had to patch code in the @rhino.fi/client-js package. This is not ideal and we should really update client-js to fix these problems. This PR is to complete part of that work.
The following files need updating in @rhino.fi/client-js to allow these patches to be removed.
All of the files above need the following code change to replace
return (withdrawalBalance = await dvf.eth.call(with
return (await dvf.eth.call(