Skip to content

chore: update sigs.k8s.io/controller-runtime to v0.23.3#1068

Merged
openshift-merge-bot[bot] merged 2 commits into
rhobs:mainfrom
simonpasquier:bump-controller-runtime
Apr 23, 2026
Merged

chore: update sigs.k8s.io/controller-runtime to v0.23.3#1068
openshift-merge-bot[bot] merged 2 commits into
rhobs:mainfrom
simonpasquier:bump-controller-runtime

Conversation

@simonpasquier
Copy link
Copy Markdown
Contributor

No description provided.

@simonpasquier simonpasquier requested a review from jgbernalp April 23, 2026 07:22
@openshift-ci openshift-ci Bot requested review from marioferh and slashpai April 23, 2026 07:22
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a136421d-26f7-4274-87aa-acd85caf717f

📥 Commits

Reviewing files that changed from the base of the PR and between fb678e2 and a5bc300.

📒 Files selected for processing (1)
  • pkg/reconciler/reconciler.go
✅ Files skipped from review due to trivial changes (1)
  • pkg/reconciler/reconciler.go

📝 Walkthrough

Walkthrough

This pull request updates the go.mod file to refresh direct and indirect module dependencies: bumps github.com/open-telemetry/opentelemetry-operator to v0.148.0, updates golang.org/x/exp to a newer commit, upgrades sigs.k8s.io/controller-runtime to v0.23.3, and refreshes several indirect OpenTelemetry and exporter modules. It removes the indirect github.com/hashicorp/go-version and drops gopkg.in/yaml.v2. Additionally, a //nolint:staticcheck suppression comment was added immediately before a Kubernetes client Patch call in pkg/reconciler/reconciler.go; no functional logic was changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate if the description relates to the changeset. Add a brief description explaining the purpose of the dependency updates and any testing or validation performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change in the changeset: updating sigs.k8s.io/controller-runtime to v0.23.3 is the primary version bump mentioned in go.mod.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@jgbernalp
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 23, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 85afcb7 into rhobs:main Apr 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants