feat: expose prometheus nodeselector and tolerations in monitoringstack CRD

[bng0y]

Allows to isolate the Prometheus pods when necessary.
Context: https://issues.redhat.com/browse/SDE-2823

[vimalk78]

If this PR changes the Prometheus managedFields, please update this test case to keep managed Fields info updated.

[simonpasquier]

Maybe the fields should be located under .spec rather than .spec.prometheusConfig and apply to all child resources of the MonitoringStack resource?

@sthaha @jan--f WDYT?

[sthaha]

Maybe the fields should be located under .spec rather than .spec.prometheusConfig and apply to all child resources of the MonitoringStack resource?

@simonpasquier, I like the idea to have a global setting for all child resources, however should we also allow each child resource to have different setting to the global one?

[sthaha]

If this PR changes the Prometheus managedFields, please update this test case to keep managed Fields info updated.

@vimalk78 shouldn't that test fail in that case 🤔

[vimalk78]

@vimalk78 shouldn't that test fail in that case

it would, but the new parameters are optional, so unless explicitly set in the object the managedFields wont change.

[simonpasquier]

@sthaha my gut feeling is that in most cases, you want the monitoring pods to run on the same set of nodes (e.g. infra) so having a top-level field is probably what makes the most sense. We can argue later if there's a need for individual settings for each component but I'd rather make the mainstream situation easy to configure.

[sthaha]

@simonpasquier +1 to having it global for now

We can argue later if there's a need for individual settings for each component but I'd rather make the mainstream situation easy to configure.

+1 to YAGNI :)

[sthaha]

@bng0y , Like @simonpasquier suggested, lets make this global and apply the same to all resources that ObO creates.

[sthaha]

Could you please consider implementing the suggestion.

[sthaha]

@bng0y , It would be great to have this feature added to ObO. Do you need help implementing this?

[jan--f]

Closing this due to age, but might still be something we want to pursue. https://issues.redhat.com/browse/COO-233

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.