chore: build static Go binaries #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the `-tags netgo,osusergo` argument to Go commands to get fully-static binaries. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
requested review from
JoaoBraveCoding and
sthaha
and removed request for
a team
Contributor
Author
|
Looking at https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/rhobs_observability-operator/381/pull-ci-rhobs-observability-operator-main-observability-operator-e2e/1721911199957782528 (which is a failed run), the logs indicate a problem with glibc: My suspicion is that the e2e.test binary isn't fully static. |
simonpasquier
requested review from
jan--f
and removed request for
JoaoBraveCoding and
sthaha
Collaborator
|
/lgtm |
jan--f
approved these changes
Nov 8, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
-tags netgo,osusergoargument to Go commands to get fully-static binaries.