address the missing upstream VERSION case#101
Merged
simonpasquier merged 1 commit intorhobs:mainfrom Nov 13, 2024
Merged
Conversation
rexagod
force-pushed
the
fix-missing-upstream-version-file-case
branch
2 times, most recently
from
b83a1bf to
9ef33c8
Compare
Member
Author
|
Both of the failing ACM workflows below were failing before this patch for the same errors. |
rexagod
force-pushed
the
fix-missing-upstream-version-file-case
branch
from
d381887 to
6c1861d
Compare
Contributor
There was a problem hiding this comment.
I wouldn't modify the acm workflow to avoid unattended side effects for them.
Address the case where the upstream VERSION file is missing, but present downstream. Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
rexagod
force-pushed
the
fix-missing-upstream-version-file-case
branch
from
6c1861d to
6a3abb9
Compare
simonpasquier
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the case where the upstream VERSION file is missing, but present downstream.