Stream TAP output line by line#68
Merged
Merged
Conversation
Spawn each test with stdout connected to a pty so its stdio sees a TTY and line-buffers, instead of block-buffering through a pipe. Without this, TAP lines were held in the child's stdio buffer and arrived in chunks. Sometimes creating the illusion that the execution had stalled. Also line-buffer 9pm's own stdout so output streams when 9pm itself is piped to another program. Add a self-test for this. Signed-off-by: Richard Alpe <richard@bit42.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawn each test with stdout connected to a pty so its stdio sees a TTY and line-buffers, instead of block-buffering through a pipe.
Without this, TAP lines were held in the child's stdio buffer and arrived in chunks. Sometimes creating the illusion that the execution had stalled.
Also line-buffer 9pm's own stdout so output streams when 9pm itself is piped to another program.
Add a self-test for this.