Add nasm for Windows cross-compile builds#39
Merged
Conversation
The aws-lc-sys crate requires nasm (Netwide Assembler) for optimized cryptographic routines when targeting x86 Windows. Without it, the i686-pc-windows-gnu build fails with 'NASM command not found'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the release CI workflow to fix Windows (GNU) cross-compilation failures by installing nasm, which is required by aws-lc-sys when building x86-target cryptographic assembly.
Changes:
- Install
nasmalongsidegcc-mingw-w64in the Windows build dependencies step of the release workflow.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/release.yml |
Adds nasm to the apt-installed dependencies for Windows cross-compile targets to prevent NASM command not found build failures. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 32-bit Windows cross-compile build failure caused by missing
nasm.Problem
The
aws-lc-syscrate (pulled in viaopenssl->rustls) requiresnasmfor assembling optimized cryptographic routines on x86 targets. The CI workflow installedgcc-mingw-w64for Windows cross-compilation but notnasm, causing builds to fail with:NASM command not found! Build cannot continue.Fix
Add
nasmto theapt installin the Windows build dependencies step.