Why is MockedRequestExtensions.Respond(HttpResponseMessage) deprecated?

[IanKemp]

The attribute on this method says

Using this overload is not recommended. Instead, use Respond(req => new HttpResponseMessage(...))

which is not helpful because it does not tell me why I should prefer the latter. The description of the commit that added that attribute is equally unhelpful.

Dopes anyone know why this method was deprecated?

[richardszalay]

Apologies for the delay, and yes agree the deprecation message could have been clearer.

When HttpResponseMessages are returned, the associated HttpRequestMessage is assigned to HttpResponseMessage.RequestMessage to match the behaviour of the real HttpClient.

The original syntax used the same HttpResponseMessage, which caused a number of use-after-dispose and race condition issues.