Pygments-based highlighting#68
Conversation
Version 0.1.5 from dev.
Merging version 0.1.7
Merge version 0.1.8 from dev
Merge version 0.1.9 from dev
Merge version 0.1.10 from dev to master
Merge version 0.1.11 from dev to master
Merge version 0.1.2 from dev to master
Conflicts: modules/battery.py
Merge v0.1.22 from dev to master.
|
Wow, great! You're fast 👍 Mostly looks good to me, but there's a few unneeded changes to logging. Specifically some logging is done via the self.app, but self.logging is also available. It's better for each module to have it's own logger, so we can see where the log messages are coming from. (All logging is routed to the root logger anyway) There are a few others lines too that use self.app.logger. If you could fix those I'll be ready to merge this. Thanks again very much, great work! I really like how the new highlighting looks. :) |
|
I also forgot that there are some old not needed imports in this PR. Also it's good to avoid They could be removed :) |
|
Ok, all unnecessary imports are removed and modules use their own logger. I was fixing conflicts and didin't notice the changes in logging... |
|
Many thanks! Merging this now. :) |
2 participants
Use pygments to tokenize the code rather than split the code into words directly. This looks much better than the previous highlighter. Now we have built-in support for over 300 languages.