Skip to content

feat(admin): restore close-signup button to detail header#19

Merged
richshaw merged 1 commit intomainfrom
feat/header-close-signup-button
Apr 30, 2026
Merged

feat(admin): restore close-signup button to detail header#19
richshaw merged 1 commit intomainfrom
feat/header-close-signup-button

Conversation

@richshaw
Copy link
Copy Markdown
Owner

@richshaw richshaw commented Apr 30, 2026

Summary

  • Restore Close signup to the signup detail header next to Preview/Export — it's now reachable from any tab instead of being buried in Settings.
  • Style matches the existing Publish button (brand-fill); shown only when status === 'open' and mutually exclusive with Publish (which only shows for drafts).
  • Drop the duplicate Close button from Settings → Danger zone now that the header owns the affordance.

The close API/service (closeActioncloseSignup) is unchanged; this is purely a UI placement fix for the regression introduced when the detail page was split into tabs (#17).

Test plan

  • pnpm lint && pnpm typecheck && pnpm test — green (92/92)
  • Manual smoke: open signup detail page for a draft, confirm header shows Publish (not Close).
  • Manual smoke: open signup detail page for an open signup, confirm header shows brand-blue Close signup, click it, status flips to closed, button disappears.
  • Manual smoke: confirm Settings tab no longer renders the Danger zone for open signups.
  • Manual smoke: closed / archived signup → header shows neither Publish nor Close.

🤖 Generated with Claude Code

Move the Close action back to the header next to Preview/Export/Publish so
it's reachable from any tab; drop the Settings → Danger zone duplicate now
that the header owns the affordance.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@richshaw richshaw merged commit b5d5d75 into main Apr 30, 2026
4 checks passed
@richshaw richshaw deleted the feat/header-close-signup-button branch April 30, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant