Open
Conversation
isOk, isErr, unwrap, and tryAsync were exported but never imported anywhere in the codebase. https://claude.ai/code/session_01LxXGg24JhSve6YvC37gEZy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the src/lib/result module by removing previously-exported helper utilities, leaving only the core Result/Ok/Err types and ok()/err() constructors.
Changes:
- Removed
isOk()andisErr()type guard helpers. - Removed
unwrap()helper that threw onErr. - Removed
tryAsync()helper for wrapping async operations intoResult.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes several utility functions from the result module that are no longer needed or have been moved elsewhere.
Changes
isOk()type guard functionisErr()type guard functionunwrap()function for extracting values from Result typestryAsync()helper for wrapping async operations in Result typesThese functions were part of the public API but are being deprecated in favor of alternative implementations or patterns.
https://claude.ai/code/session_01LxXGg24JhSve6YvC37gEZy