fix: Remove unreliable IsBackOfficeRequest check from IsBlockPreviewRequest#241
Merged
rickbutterfield merged 1 commit intov5/devfrom Feb 12, 2026
Merged
Conversation
…equest The IsBackOfficeRequest() check was returning false for BlockPreview API routes (/umbraco/block-preview/api/...) because Umbraco's heuristic doesn't recognise custom backoffice routes. This led to a previous workaround (5b4fc53) changing && to ||, which caused pages with URLs starting with /umbraco (e.g. /umbraco-explained) to incorrectly return true on the frontend. The isBlockPreviewController check alone is sufficient — it verifies the exact controller and action. Fixes #239 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes false positives in IsBlockPreviewRequest() on frontend pages whose URLs start with /umbraco by removing reliance on Umbraco’s heuristic IsBackOfficeRequest() check and using exact controller/action matching instead.
Changes:
- Removed the
IsBackOfficeRequest()dependency and itsUmbraco.Extensionsusing. - Updated
IsBlockPreviewRequest()to returntrueonly when the request targetsBlockPreviewApiControllerpreview actions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsBackOfficeRequest()check fromIsBlockPreviewRequest()which was causing false positives on frontend pages with URLs starting with/umbraco(e.g./umbraco-explained)isBlockPreviewControllercheck alone is sufficient — it verifies the exact controller and action matchIsBackOfficeRequest()heuristic doesn't recognise custom backoffice API routes like/umbraco/block-preview/api/..., which led to a previous&&→||workaround (5b4fc53) that introduced the bugFixes #239
Test plan
/umbraco(e.g./umbraco-explained)IsBlockPreviewRequest()to conditionally render🤖 Generated with Claude Code