Merged
Conversation
Contributor
Author
|
This failure is caused by the fact that the highlighter tool is commented out in the colors dict rmc/src/rmc/exporters/writing_tools.py Line 30 in 275110a I think this was done because the highlighter's color is actually stored/computed elsewhere? This is related to ricklupton/rmscene#44, right @ChenghaoMou? |
Contributor
|
Yes, it is related. #34 should fix this issue once the new version of rmscene is integrated. |
Owner
|
I know it's been a while, but thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a .rm file which uses the Highlighter tool with color code = 9.
This shouldn't fail, but it does, even on rmc 0.3.0