Equal Line Spacing for TextLabel in Integrations and Web App

[gabi2022]

When I started to use Integrations, I found my Text Labels were visually "falling apart".

I found the relevant code fragment in the minified rayOptics.js. I recommend to change
t.fontBoundingBoxAscent?s+=t.fontBoundingBoxAscent+t.fontBoundingBoxDescent:s+=1.5*this.fontSize
to
t.fontBoundingBoxAscent?s+=t.fontBoundingBoxAscent+t.fontBoundingBoxDescent:s+=1.15*this.fontSize

[ricktu288]

The minified code you mention is built from the source code at

ray-optics/src/core/sceneObjs/other/TextLabel.js

Line 157 in 6956536

y_offset += this.fontSize * 1.5;

and is the same for both the web app version and the integration version, and is a fallback when fontBoundingBoxAscent is not supported on the environment. So it seems that in your case the browser supports it (and hence using the actual line height) and the integration environment doesn't (and thus fallback to 1.5).

Things to consider which I am not sure for now:

1. How often does this fallback happens (in particular, is it always the case of node-canvas where the integration is used.
2. Whether 1.15 will cause some non-Latin scripts to overlap between lines

[gabi2022]

I'd recommend a golden average of x1.15
Anyway, I think really few people would notice a difference for any value between x1.11 and x1.22.
Just x1.5 is a bit far off.

Thanks again for giving me colors and dashes :)

[ricktu288]

Changed to 1.15