fix: correct macOS binary name expected in self-update tarball#107
Merged
JosiahParry merged 1 commit intomainfrom Mar 22, 2026
Merged
fix: correct macOS binary name expected in self-update tarball#107JosiahParry merged 1 commit intomainfrom
JosiahParry merged 1 commit intomainfrom
Conversation
The macOS CI pipeline creates tarballs by cd-ing into the bin directory
before running gtar, so the tarball contains a flat "ricochet" entry.
The code was incorrectly looking for "ricochet/{version}/bin/ricochet"
which never matched, causing self-update to fail on macOS.
Fixes #100
JosiahParry
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cd-ing into thebindirectory before runninggtar, so the tarball contains a flatricochetentry. The code was incorrectly looking forricochet/{version}/bin/ricochetwhich never matched, causingself-updateto fail on macOS.extract_binary_from_tarballcovering exact match, filename fallback, not-found error, and platform-specific binary naming.Fixes #100