Conversation
**Major API consolidation:** - Renames Configuration.active_states → active_leaf_states (clear semantics) - Renames Configuration.active_ancestors → all_active_states (intuitive naming) - Removes redundant wrapper functions from StateChart and Interpreter modules - All active state queries now go directly to Configuration (single source of truth) **Architecture improvements:** - Eliminates multiple confusing ways to get active states - Reduces maintenance overhead with single canonical implementation - Clearer module responsibilities: Configuration owns all active state logic - Self-documenting function names prevent usage errors **Comprehensive updates:** - Updated all 857 tests to use new Configuration API directly - Added Configuration aliases to test files requiring them - Fixed history tracking to use all_active_states for proper shallow history computation - Updated README examples and documentation **Breaking changes:** - StateChart.active_states/1 and Interpreter.active_states/1 functions removed - StateChart.active_ancestors/1 and Interpreter.active_ancestors/1 functions removed - All active state queries must now use Configuration module directly **Benefits:** - Zero ambiguity in function naming and behavior - Reduced API surface area with focused responsibility - Better maintainability with single source of truth - Cleaner architecture with explicit module dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove legacy delegate functions from Statifier module - Update all usages to use proper module references directly - Implement proper logging in Interpreter.initialize for validation warnings - Clean up unused aliases This change forces users to be explicit about which modules they're calling, improving code clarity and removing API ambiguity. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch consolidates and cleans up the active states API while removing backwards compatibility layers for a more maintainable and explicit codebase.
Key Changes:
API Consolidation:
Backwards Compatibility Cleanup:
Code Quality Improvements:
Benefits:
All 857 tests pass with 91.2% code coverage maintained throughout the refactoring.