Add support for an expiration option. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
…dynamically, the keys do not naturally expire and will gradually build up in Redis. This assumes you don't have exceptionally long running critical sections as no expiration is set on the grabbed_key. In theory there could be some point within exists_or_create! where the exists_key expires between the getset and the renewal of the expiration, but this setting would be only appropriate when there is some definitive time the lock is no longer useful like a bidding window that has closed
jcalvert
force-pushed
the
expiring_locks
branch
from
128baa0 to
21520c8
Compare
jcalvert
added a commit
that referenced
this pull request
Oct 29, 2014
Add support for an expiration option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are creating semaphores dynamically, the keys do not naturally expire and will gradually build up in Redis. This assumes you don't have exceptionally long running critical sections as no expiration is set on the grabbed_key. In theory there could be some point within exists_or_create! where the exists_key expires between the getset and the renewal of the expiration, but this setting would be only appropriate when there is some definitive time the lock is no longer useful like a bidding window that has closed