Feature: Improve local development setup#354
Merged
camfairchild merged 7 commits intomainfrom Apr 30, 2026
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
ibraheem-abe
approved these changes
Apr 30, 2026
Collaborator
|
In my branch for openrouter I had made the changes for S3 endpoint, should I removed them or cherry picking here makes more sense? |
Contributor
Author
Me and @clementblaise synced and since this PR is smaller and will probably be merged first we think it's best to keep the S3 changes here and then Clement can merge these changes into his branch 👌 |
camfairchild
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
This PR introduces a couple of changes to improve the local development setup:
S3_endpoint_urlthat allows the user to specify a different S3 URL from the standard AWS one. This is especially useful when using S3 mocks locallyutils/s3.pylogic to aggregate the s3 client initialization logic into a single methoddocker-compose.yamlfile that allows the developer to run the Postgres DB, Adobe S3 mock and the api service with a single command. This should only be used for development purposes