Implement automatic date tracking for job start and finish times#24
Merged
Implement automatic date tracking for job start and finish times#24
Conversation
Co-authored-by: nolan1999 <54246789+nolan1999@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update date started, date finished on status updates
Implement automatic date tracking for job start and finish times
Aug 4, 2025
nolan1999
reviewed
Aug 4, 2025
| user_email = mapped_column(String, nullable=True) # required for notifications | ||
| job_name = mapped_column(String) | ||
| date_created = mapped_column(DateTime, default=datetime.datetime.utcnow) | ||
| date_created = mapped_column(DateTime, default=lambda: datetime.datetime.now(datetime.timezone.utc)) |
Member
There was a problem hiding this comment.
please keep the current version
Contributor
Author
There was a problem hiding this comment.
Reverted the date_created field to use the original datetime.utcnow as requested in commit 5a937fd.
Co-authored-by: nolan1999 <54246789+nolan1999@users.noreply.github.com>
1490620 to
e538ac9
Compare
e538ac9 to
7dd65f6
Compare
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
nolan1999
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jobstable containsdate_startedanddate_finishedcolumns that were never being updated. This PR implements automatic tracking of these timestamps during job lifecycle events.Changes Made
Enhanced Job Status Updates (
api/endpoints/job_update.py):date_startedwhen job status changes to"pulled"(first time only)date_finishedwhen job reaches terminal states ("finished"or"error") (first time only)Noneto prevent overwritingComprehensive Test Coverage:
date_finishedJob Lifecycle Timeline
Benefits
Example Usage
The implementation uses minimal, surgical changes focused only on the job status update endpoint while maintaining full backward compatibility.
Fixes #14.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.