This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Improve CLI 'capsule deploy' and fixed bug with deploying in Docker#117
Merged
MatiasFrank merged 3 commits intomainfrom Sep 20, 2023
Merged
Improve CLI 'capsule deploy' and fixed bug with deploying in Docker#117MatiasFrank merged 3 commits intomainfrom
MatiasFrank merged 3 commits intomainfrom
Conversation
capsule deploy: Now infers which Rig build is referenced from incomplete quries, e.g. passing only a digest prefix Docker bug: We changed how Rig builds are id'ed to always contain the image digest. Docker can fine pull remote images when they are specified with registry/repo[:tag]@digest, but local builds cannot (for some reason...) be referenced by both repo and digest. Either you must supply a digest or you must supply a registry/repo[:tag]. Therefore all deploys in Docker failed, and I had to hack around the buildID in docker :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capsule deploy: Now infers which Rig build is referenced from incomplete
quries, e.g. passing only a digest prefix
Docker bug: We changed how Rig builds are id'ed to always contain the
image digest. Docker can fine pull remote images when they are specified
with registry/repo[:tag]@digest, but local builds cannot (for some reason...)
be referenced by both repo and digest.
Either you must supply a digest or you must supply a registry/repo[:tag].
Therefore all deploys in Docker failed, and I had to hack around the buildID in docker :(