This repository was archived by the owner on Mar 24, 2025. It is now read-only.
🐛 Fix clash between k8s svc discovery and rig env var#25
Merged
blacksails merged 1 commit intorigdev:mainfrom Sep 3, 2023
Merged
Conversation
Kubernetes service discovery creates an environment variable called `<service-name>-PORT` for each service in the namespace where a pod runs. The main service in the chart used the fullname helper as name. When using rig as release name this resulted in the service being called `rig`. This then means that each pod in the namespace would get an environment variable called `RIG_PORT`. This clashes with the environment override of `port` in the rig config. This fix changes the service name by adding `-svc` as suffix. The service discovery variable will hence be `RIG_SVC_PORT` and no longer cause a clash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes service discovery creates an environment variable called
<service-name>-PORTfor each service in the namespace where a podruns. The main service in the chart used the fullname helper as name.
When using rig as release name this resulted in the service being called
rig. This then means that each pod in the namespace would get anenvironment variable called
RIG_PORT. This clashes with theenvironment override of
portin the rig config.This fix changes the service name by adding
-svcas suffix. Theservice discovery variable will hence be
RIG_SVC_PORTand no longercause a clash.