This repository was archived by the owner on Mar 24, 2025. It is now read-only.
♻️ Move proto definitions of revisions#959
Merged
MatiasFrank merged 1 commit intomainfrom May 22, 2024
Merged
Conversation
|
📝 Docs preview ready at https://pr959.docs.prod.rig.dev |
Unfortunately, putting all revisions in their own package lead to circular imports as the CapsuleRevision imports from the Capsule proto package. Moving all revisions into their own respective packages should mitigate this in the future.
MatiasFrank
force-pushed
the
sot-proto-move
branch
from
f1b79ad to
ce48ca1
Compare
Contributor
|
Very nice, thank you! |
andersjohnsen
approved these changes
May 22, 2024
|
📝 Docs preview ready at https://pr959.docs.prod.rig.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, putting all revisions in their own package lead to
circular imports as the CapsuleRevision imports from the Capsule proto package.
Moving all revisions into their own respective packages should mitigate this in the future.