Merged
Conversation
Add a DEFVAR form for *MOCKED-NAMESPACE* to avoid an undefined
variable warning when compiling.
Also, check *MOCKED-NAMESPACE* first in CURRENT-NAMESPACE to allow
overriding the namespace even if one of *{LOAD,COMPILE-FILE}-TRUENAME*
is defined.
CALL and ARGS are not used in %RPC-CALL-RAW-REQUEST. These style-warnings crept as part of the refactoring in #99.
stylewarning
approved these changes
Dec 12, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DEFVAR for
*MOCKED-NAMESPACE*and prefer it inCURRENT-NAMESPACEAdd a
DEFVARform for*MOCKED-NAMESPACE*to avoid an undefined variable warning when compiling.Also, check
*MOCKED-NAMESPACE*first inCURRENT-NAMESPACEto allow overriding the namespace even if one of*{LOAD,COMPILE-FILE}-TRUENAME*is defined.Fix style-warning about unused args in
%RPC-CALL-RAW-REQUESTCALLandARGSare not used in%RPC-CALL-RAW-REQUEST. These style-warnings crept as part of the refactoring in #99.