Restrict msgpack dependency to <1.0#119
Conversation
The msgpack 1.0 release includes some changes that break deserialization of certain RewriteArithmeticResponse calls from pyquil. Restrict the version to <1.0 for now until we are ready to test and fix an upgrade to 1.0. Updates #118 See also: rigetti/pyquil#1178
|
gitlab pipeline status is here: |
| @@ -1,4 +1,9 @@ | |||
| msgpack == 0.6 | |||
| # If you change the requirements here, don't forget to make the | |||
| # corresponding change in the conda-forge rcpq-feedstock here: | |||
There was a problem hiding this comment.
Do we need to do anything feedstock-related this time around?
There was a problem hiding this comment.
Trying to figure that out now. I think we probably want to release this as rpcq 3.0.1 (or maybe 3.1.0 since we added a new message recently?), then bump the version in the rpcq-feedstock.
Alternatively, I could push a change updating the dependency in the rpcq-feedstock and just increment the build number, then it seems like conda-forge has some automagical bot that will open a PR bump the version once we release a new PYPI package.
There was a problem hiding this comment.
Looks like the conda-forge auto-update bot actually reminds you to check the dependencies when it opens a PR to update the feedstock, so maybe the comment here is less helpful than I thought. I suppose it doesn't hurt...
There was a problem hiding this comment.
With that said, I think releasing a new RPCQ version, then updating the rpcq-feedstock dependencies in the PR opened by the auto-update bot makes sense.
4 participants
The msgpack 1.0 release includes some changes that break deserialization of certain
RewriteArithmeticResponsecalls from pyquil. Restrict the version to <1.0 for now until we are ready to test and fix an upgrade to 1.0.Also, add a reminder to requirements.txt about updating the rpcq-feedstock.
Updates #118
See also:
rigetti/pyquil#1178