Merged
Conversation
ecpeterson
commented
Mar 27, 2019
|
|
||
| ;; send the client response, whether success or failure | ||
| (%push-raw-request receiver identity empty-frame (serialize reply))))) | ||
| (handler-case |
Contributor
Author
There was a problem hiding this comment.
Emacs reindented this for me, but the real change is the handler-bind and the :|warnings| slot initializers.
ecpeterson
force-pushed
the
serialize-warnings
branch
from
9b4986e to
ffcb9b1
Compare
stylewarning
approved these changes
Apr 1, 2019
Contributor
stylewarning
left a comment
stylewarning
left a comment
There was a problem hiding this comment.
A few small things; looks fine overall.
caryan
reviewed
Apr 1, 2019
stylewarning
suggested changes
Apr 11, 2019
|
|
||
| (defmethod %serialize ((payload cons)) | ||
| (loop :for elt :in payload :collect (%serialize elt))) | ||
| (map 'vector #'%serialize payload)) |
Contributor
There was a problem hiding this comment.
can we nix serializing conses altogether?
Contributor
Author
There was a problem hiding this comment.
If you were to ask me: yes. If you were to ask someone else with more principles about backwards compatibility: no, or not yet.
|
|
||
| (defmethod %deserialize ((payload cons)) | ||
| (loop :for elt :in payload :collect (%deserialize elt))) | ||
| (map 'vector #'%deserialize payload)) |
ecpeterson
force-pushed
the
serialize-warnings
branch
from
3e3d16a to
184e414
Compare
stylewarning
approved these changes
Apr 12, 2019
Contributor
|
This LGTM. What changes ripple through the stack? |
Contributor
Author
|
AFAICT, this is the only ripple: quil-lang/quilc#188 . |
Contributor
|
let's merge after the weekend |
Contributor
|
Weekend is done; anybody want to merge? (I'm not a CODEOWNER.) |
caryan
reviewed
Apr 16, 2019
caryan
reviewed
Apr 16, 2019
caryan
reviewed
Apr 16, 2019
Contributor
|
Only serious concern is whether this will swallow warnings in the server logs. |
caryan
approved these changes
Apr 18, 2019
stevenheidel
approved these changes
Apr 18, 2019
Contributor
Author
|
ty everyone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43: captures Server-side warnings and re-raises them on the Client side.