Skip to content

fix : fix panic due to uri parse error #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-anshul merged 1 commit into from
Feb 26, 2025
Merged

fix : fix panic due to uri parse error #6772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion runtime/pkg/rduckdb/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,9 @@ func (d *db) openDBAndAttach(ctx context.Context, uri, ignoreTable string, read

db = sqlx.NewDb(otelsql.OpenDB(connector), "duckdb")
defer func() {
if dbErr != nil {
// there are too many error paths after this so closing the db in a defer seems better
// but the dbErr can be non nil even before function reaches this point so need to check for db is non nil
if dbErr != nil && db != nil {
_ = db.Close()
}
}()
Expand Down
Loading