Skip to content

Conversation

@AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Mar 26, 2025

  • Move the home bookmark out of bookmarks dropdown.
  • The button should be available even when there is no home bookmark. Should take the user to blank dashboard, i.e. a url without any params.
  • Fix issue where the button doesnt apply the state due to race condition. Not worth fixing on main's code since there are changes coming in APP-59: feat: Restore certain explore user state across page loads. #6964
  • Figure out what we will show on a shared url and rill-dev. We will not show this for shared-url and rill-dev.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde force-pushed the feat/home-bookmark-ux-changes branch from 24e6f9c to f593189 Compare April 4, 2025 04:33
@AdityaHegde AdityaHegde marked this pull request as ready for review April 4, 2025 04:36
@AdityaHegde AdityaHegde requested a review from ericpgreen2 April 4, 2025 04:36
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get a Product review from @jkhwu. A few UXQA I see:

  1. The Home button does not have the same hover state as the buttons it's next to
  2. Should the Home button be disabled when either there's no Home bookmark or you're currently viewing the Home state? Disabled + tooltip to explain why.
  3. It feels a bit off that the "Bookmark your current view as home" action exists in a dropdown that's anchored off a different button. Maybe, when there's no Home bookmark, the Home button should open a dropdown menu with the prompt?(CC @jkhwu)

Looks like the Home bookmark e2e test needs to be updated.

@ericpgreen2 ericpgreen2 requested a review from jkhwu April 4, 2025 07:45
@AdityaHegde
Copy link
Collaborator Author

AdityaHegde commented Apr 4, 2025

Thanks @ericpgreen2

  1. Ya lemme fix that.
  2. We can disable when the current state is equal to the button's link. But we need it to take the user to blank dashboard when there is no home bookmark. This is per requirement, cc @mindspank
  3. Will defer to @jkhwu
  4. Will fix the tests.

@ericpgreen2 ericpgreen2 requested a review from mindspank April 8, 2025 17:17
@ericpgreen2
Copy link
Contributor

Code looks good. I'll defer to @mindspank to approve as product owner, as I have reservations about this:

It feels a bit off that the "Bookmark your current view as home" action exists in a dropdown that's anchored off a different button.

@AdityaHegde AdityaHegde requested a review from ericpgreen2 April 14, 2025 11:34
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise, IMO we need to make clear the difference between these two menu items. They look "equal", yet one should be clearly a navigation action and one should clearly be not. A couple ideas:

  1. Adding a separator between the menu items
  2. Editing the "Home" copy to be "Go to home"
  3. Moving the "Go to home" menu item above the other, since it'll be the more common action.

@jkhwu, any other thoughts on this?

image

export let gray = false;
export let danger = false;
export let preload = true;
export let highlight = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the same term from Figma: "active"

@AdityaHegde AdityaHegde force-pushed the feat/home-bookmark-ux-changes branch from 0e4df1d to aa4a966 Compare April 14, 2025 16:25
@AdityaHegde AdityaHegde requested a review from ericpgreen2 April 15, 2025 05:46
@AdityaHegde AdityaHegde merged commit 9dfca63 into main Apr 15, 2025
9 checks passed
@AdityaHegde AdityaHegde deleted the feat/home-bookmark-ux-changes branch April 15, 2025 10:35
grahamplata pushed a commit that referenced this pull request Apr 15, 2025
* Move home bookmark to a separate button

* Fix url not updating state

* Cleanup

* Update tests

* Add active/inactive states

* Add home bookmark dropdown

* Fix E2E

* Update UX

* Add tooltip for delete home bookmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants