chore: bump Orval and TanStack Query #6986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangregoryholmes
requested review from
AdityaHegde,
begelundmuller,
djbarnwal,
ericpgreen2 and
lovincyrus
Contributor
|
Love this! Thank you for doing this! Some initial UXQA:
|
8 tasks
NamanMahor
pushed a commit
that referenced
this pull request
Apr 10, 2025
* init commit * type and api fixes * chore: remove unused import * fix: add back gc param * fix: type signature * fix: type and api updates * fix: remove logs * refac: remove refetchOnMount override * fix: remove log * fix: type issue * fix: type fixes * fix: attempt to fix breadcrumb test * Two bugfixes * fix: leaderboard loading state, deprecate useModelHasTimeSeries * fix: change implementation to use isPending * Re-generate admin client with `infiniteQueryParams` * Add `getNextPageParam` functions to admin infinite queries * chore: update orval to 7.8, regen clients * fix: type fix * fix: test retries --------- Co-authored-by: Eric P Green <ericpgreen2@gmail.com>
grahamplata
pushed a commit
that referenced
this pull request
Apr 14, 2025
* init commit * type and api fixes * chore: remove unused import * fix: add back gc param * fix: type signature * fix: type and api updates * fix: remove logs * refac: remove refetchOnMount override * fix: remove log * fix: type issue * fix: type fixes * fix: attempt to fix breadcrumb test * Two bugfixes * fix: leaderboard loading state, deprecate useModelHasTimeSeries * fix: change implementation to use isPending * Re-generate admin client with `infiniteQueryParams` * Add `getNextPageParam` functions to admin infinite queries * chore: update orval to 7.8, regen clients * fix: type fix * fix: test retries --------- Co-authored-by: Eric P Green <ericpgreen2@gmail.com>
grahamplata
pushed a commit
that referenced
this pull request
Apr 14, 2025
* init commit * type and api fixes * chore: remove unused import * fix: add back gc param * fix: type signature * fix: type and api updates * fix: remove logs * refac: remove refetchOnMount override * fix: remove log * fix: type issue * fix: type fixes * fix: attempt to fix breadcrumb test * Two bugfixes * fix: leaderboard loading state, deprecate useModelHasTimeSeries * fix: change implementation to use isPending * Re-generate admin client with `infiniteQueryParams` * Add `getNextPageParam` functions to admin infinite queries * chore: update orval to 7.8, regen clients * fix: type fix * fix: test retries --------- Co-authored-by: Eric P Green <ericpgreen2@gmail.com>
grahamplata
pushed a commit
that referenced
this pull request
Apr 15, 2025
* init commit * type and api fixes * chore: remove unused import * fix: add back gc param * fix: type signature * fix: type and api updates * fix: remove logs * refac: remove refetchOnMount override * fix: remove log * fix: type issue * fix: type fixes * fix: attempt to fix breadcrumb test * Two bugfixes * fix: leaderboard loading state, deprecate useModelHasTimeSeries * fix: change implementation to use isPending * Re-generate admin client with `infiniteQueryParams` * Add `getNextPageParam` functions to admin infinite queries * chore: update orval to 7.8, regen clients * fix: type fix * fix: test retries --------- Co-authored-by: Eric P Green <ericpgreen2@gmail.com>
grahamplata
pushed a commit
that referenced
this pull request
Apr 15, 2025
* init commit * type and api fixes * chore: remove unused import * fix: add back gc param * fix: type signature * fix: type and api updates * fix: remove logs * refac: remove refetchOnMount override * fix: remove log * fix: type issue * fix: type fixes * fix: attempt to fix breadcrumb test * Two bugfixes * fix: leaderboard loading state, deprecate useModelHasTimeSeries * fix: change implementation to use isPending * Re-generate admin client with `infiniteQueryParams` * Add `getNextPageParam` functions to admin infinite queries * chore: update orval to 7.8, regen clients * fix: type fix * fix: test retries --------- Co-authored-by: Eric P Green <ericpgreen2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rill has been stuck on version 4.29 of TanStack query and version 6.12 of Orval for years. It appears that the primary hurdle was a small API change regarding the use of a custom
queryClientin TanStack Query v5 that Orval was not accounting for.A PR that I submitted against Orval (orval-labs/orval#1992) to resolve that issue was released with version 7.8 https://github.com/orval-labs/orval/releases/tag/v7.8.0
queryClientListMagicAuthTokens,ListOrganizationInvites, andListOrganizationMemberUsersand instead generates them with Orvaladd-signal-argumenttransformer as this has been a native feature of Orval since 2022 feat(clients): add query cancellation orval-labs/orval#357invalidateQueries,refetchQueriesand related functionsanytounknownChecklist: