Skip to content

Conversation

@mindspank
Copy link
Contributor

@mindspank mindspank commented Mar 27, 2025

Adds allow_custom_time_range to explore and canvas yaml. Defaults to true

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tangential, this makes me realize that we don't have autocomplete in the Explore code editor, but we should!

@mindspank mindspank merged commit e9b687c into main Mar 31, 2025
13 checks passed
@mindspank mindspank deleted the feat/custom-range branch March 31, 2025 16:37
grahamplata pushed a commit that referenced this pull request Apr 14, 2025
* feat: toggle for custom timerange

* fix: lint

* fix: missed vars

* fix: go tests

* fix: more go tests

* fix: should be last spec

* nit: move proto prop

* fix: go lint
grahamplata pushed a commit that referenced this pull request Apr 14, 2025
* feat: toggle for custom timerange

* fix: lint

* fix: missed vars

* fix: go tests

* fix: more go tests

* fix: should be last spec

* nit: move proto prop

* fix: go lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants