-
Notifications
You must be signed in to change notification settings - Fork 164
feat: toggle for custom timerange #6994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
approved these changes
Mar 31, 2025
Contributor
begelundmuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ericpgreen2
approved these changes
Mar 31, 2025
Contributor
ericpgreen2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tangential, this makes me realize that we don't have autocomplete in the Explore code editor, but we should!
grahamplata
pushed a commit
that referenced
this pull request
Apr 14, 2025
* feat: toggle for custom timerange * fix: lint * fix: missed vars * fix: go tests * fix: more go tests * fix: should be last spec * nit: move proto prop * fix: go lint
grahamplata
pushed a commit
that referenced
this pull request
Apr 14, 2025
* feat: toggle for custom timerange * fix: lint * fix: missed vars * fix: go tests * fix: more go tests * fix: should be last spec * nit: move proto prop * fix: go lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
allow_custom_time_rangeto explore and canvas yaml. Defaults totrueChecklist: