fix: canvas refresh time in rill cloud #7292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
May 12, 2025
Comment on lines
+92
to
+100
| // Find the max refresh time of all the resources that are referenced by the components in the dashboard | ||
| const maxRefresh = dashboard.meta.refs | ||
| .map((r) => allResources.get(`${r?.kind}_${r?.name}`)) | ||
| .filter((c) => c.meta.refs.length) // filter out resources that don't have refs such as markdown and image | ||
| .map((m) => | ||
| allResources.get(`${m.meta.refs[0].kind}_${m.meta.refs[0].name}`), | ||
| ) | ||
| .map((m) => m.metricsView.state?.modelRefreshedOn) | ||
| .reduce((max, c) => (c > max ? c : max)); |
Contributor
There was a problem hiding this comment.
This chaining feels a bit clever. It might be easier to read if you broke it up (kind of like the previous code)?
mindspank
added a commit
that referenced
this pull request
May 30, 2025
* fix: find max refresh for components * nit: comments * fix: format
grahamplata
pushed a commit
that referenced
this pull request
Jun 4, 2025
* fix: find max refresh for components * nit: comments * fix: format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterates over components to find the latest underlying refresh time of a model.
Checklist: