feat: Add a mirroring GetProject API to local service to get project permissions during deploy #7297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
approved these changes
Jun 4, 2025
proto/rill/admin/v1/api.proto
Outdated
Comment on lines
974
to
975
| // Skips fetching deployment and jwt related to querying deployment | ||
| bool skip_deployment = 6; |
Contributor
There was a problem hiding this comment.
Are you going to be calling this endpoint in a poll loop? Otherwise, I'd prefer to just keep the API simple and always return the deployment info (it's relatively cheap to generate).
Collaborator
Author
There was a problem hiding this comment.
Right now it is used only when we select a project to re-deploy to. I can remove this if it is cheap.
grahamplata
pushed a commit
that referenced
this pull request
Jun 4, 2025
…permissions during deploy (#7297) * Add a mirring GetProject API to local service * Remove skip_deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During deploy we need to prefetch project permissions and show a modal for requesting access.
Adding
GetProjectto local service. This doesnt fetch deployment and jwt, to achieve this addingskip_deploymentto admin API.Checklist: