Skip to content

Conversation

@ericpgreen2
Copy link
Contributor

Closes ENG-784

Note: I've checked Scheduled Reports, and we do not have this same issue.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericpgreen2 ericpgreen2 requested a review from AdityaHegde June 3, 2025 02:48
@ericpgreen2 ericpgreen2 self-assigned this Jun 3, 2025
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why this is not an issues for reports. The link in ReportMetadata and the gotoExplorePage have similar code as in alerts.

@ericpgreen2
Copy link
Contributor Author

Curious why this is not an issues for reports

  • For Alerts, we provide a web_open_path annotation. Confusingly, we don't directly navigate to the web_open_path, but instead we parse it for the exploreName, which we use to compose a different URL (one with URL state). The bug was that we weren't correctly parsing the web_open_path for the exploreName when the exploreName included spaces.
  • For Reports, we no longer provide a web_open_path annotation. Instead, we explicitly provide the explore resource name. So, there's no bug with Reports, as they don’t rely on web_open_path at all.

It'd be a good clean-up if we used the Report approach for Alerts too.

@ericpgreen2 ericpgreen2 merged commit bf28f17 into main Jun 3, 2025
13 checks passed
@ericpgreen2 ericpgreen2 deleted the fix-open-alert-for-explore-with-space-in-name branch June 3, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants