Fix inconsistent .git suffix in Git remotes
#7421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
approved these changes
Jun 6, 2025
begelundmuller
added a commit
that referenced
this pull request
Jun 6, 2025
* Fix inconsistent `.git` suffix in Git remotes * Minor UI fixes * Ensure normalized remotes have .git * Repeat migration 0070 * Fix the fix * Comment * Self review --------- Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
8 tasks
grahamplata
pushed a commit
that referenced
this pull request
Jun 13, 2025
* Fix inconsistent `.git` suffix in Git remotes * Minor UI fixes * Ensure normalized remotes have .git * Repeat migration 0070 * Fix the fix * Comment * Self review --------- Co-authored-by: Aditya Hegde <adityahegderocks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent Rill-managed Git refactors, we started storing Git remotes with the
.gitsuffix instead of without it. This change did not account for all the different cases where we process Github URLs and Git remotes.This has lead to issues where Git pushes become ineffective because the Github webhooks don't correctly match to the repository's associated project(s).
This PR attempts to completely standardize on generic Git remotes with the
.gitsuffix instead of Github web URLs. To ensure completeness, I have audited and changed almost every occurrence of the termGithubURLtoGitRemote(and related spellings likegithubURLandgithub_url). I hope we now consistently process Git remotes with the.gitsuffix everywhere.For backward compatibility with old CLIs, this PR also maps any incoming
GitRemoteargument to apply a.gitsuffix if not already present.Checklist: