feat: markdown component #8432
Merged
feat: markdown component #8432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
requested changes
Dec 4, 2025
begelundmuller
requested changes
Dec 5, 2025
grahamplata
force-pushed
the
feat/markdown-component-clean
branch
from
186ce8f to
21358ca
Compare
grahamplata
force-pushed
the
feat/markdown-component-clean
branch
from
21358ca to
df85bcc
Compare
AdityaHegde
requested changes
Dec 8, 2025
web-common/src/features/canvas/components/markdown/Markdown.svelte
Outdated
Show resolved
Hide resolved
AdityaHegde
approved these changes
Dec 9, 2025
Collaborator
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Just a small nit. Otherwise UI changes looks good.
web-common/src/features/canvas/components/markdown/Markdown.svelte
Outdated
Show resolved
Hide resolved
begelundmuller
approved these changes
Dec 9, 2025
k-anshul
pushed a commit
that referenced
this pull request
Dec 11, 2025
* Add templating and formatting support to markdown component * support multiple rows and fields * revert * split into another funcs * handle format tokens and update tests * dont format dims * use JSON payload for the token params * reuse lookup func nit * tidy * update * handle json and errors * commenta * handle nulls * format * ts * nit * Review * Review --------- Co-authored-by: Graham Plata <graham.plata@gmail.com> Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSERT DESCRIPTION HERE
Checklist: