Skip to content

Stop coercing ssl true in clickhouse cloud dsn save anyway #8543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovincyrus merged 2 commits into from
Dec 19, 2025
Merged

Stop coercing ssl true in clickhouse cloud dsn save anyway #8543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0971d9f
stop coercing ssl true in clickhouse cloud dsn save anyway
lovincyrus Dec 18, 2025
ca0a21d
readability
lovincyrus Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion web-common/src/features/sources/modal/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,14 @@ export function applyClickHouseCloudRequirements(
connectorType: ClickHouseConnectorType,
values: Record<string, unknown>,
): Record<string, unknown> {
if (connectorName === "clickhouse" && connectorType === "clickhouse-cloud") {
// Only force SSL for ClickHouse Cloud when the user is using individual params.
// DSN strings encapsulate their own protocol, so we should not inject `ssl` there.
const isDsnBased = "dsn" in values;
const shouldEnforceSSL =
connectorName === "clickhouse" &&
connectorType === "clickhouse-cloud" &&
!isDsnBased;
if (shouldEnforceSSL) {
return { ...values, ssl: true } as Record<string, unknown>;
}
return values;
Expand Down
Loading