Skip to content

feat (AI): UI for sharing AI conversations#8664

Merged
ericpgreen2 merged 10 commits intomainfrom
ui-for-sharing-ai-conversations
Feb 3, 2026
Merged

feat (AI): UI for sharing AI conversations#8664
ericpgreen2 merged 10 commits intomainfrom
ui-for-sharing-ai-conversations

Conversation

@ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Jan 16, 2026

image

Follows the Platform support, closes APP-643

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@ericpgreen2 ericpgreen2 self-assigned this Jan 16, 2026
@ericpgreen2 ericpgreen2 marked this pull request as ready for review January 21, 2026 21:04
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The share button feels like out of place in full page chat. Can we move it closer to the center perhaps?
Screenshot 2026-01-22 at 11 22 32 AM

// TESTS
// =============================================================================

describe("Conversation", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: lets move the tests just below mocks. It reads better IMO, tests 1st then all the utils and constants.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have setup-before-tests through our codebase. Mind if we just keep as is? Something feels weird about putting constants near the bottom of the file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm its a separate conversation I guess. It doesnt help to read constants without knowing what the tests are doing.

…versations

# Conflicts:
#	web-common/src/features/chat/layouts/fullpage/FullPageChat.svelte
#	web-common/src/features/chat/layouts/sidebar/ConversationHistoryMenu.svelte
#	web-common/src/features/chat/layouts/sidebar/SidebarHeader.svelte
@ericpgreen2
Copy link
Contributor Author

The share button feels like out of place in full page chat. Can we move it closer to the center perhaps?

Restating our Slack convo:

  • For the full-page chat when a conversation has not yet been started— I agree this is off. I've removed the button from this view.
  • For the full-page chat when a conversation is ongoing— per @Di7design's advice, I've kept the button in the far right.

Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Just make sure the diffs for color changes match our new design system.

@ericpgreen2 ericpgreen2 merged commit f1814df into main Feb 3, 2026
14 checks passed
@ericpgreen2 ericpgreen2 deleted the ui-for-sharing-ai-conversations branch February 3, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants