Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds automated integration tests for admin runtime deployment flows. The changes enable testing of deployment lifecycle operations including project deployment, environment variable updates, stopping, and restarting deployments.
Changes:
- Enhanced test runtime to conditionally enable config reloader based on host access settings
- Extended testadmin fixture to optionally include an embedded runtime server for integration testing
- Exposed ReconcileDeploymentWorker constructor for direct invocation in tests
- Added comprehensive integration test covering deployment lifecycle scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| runtime/testruntime/testruntime.go | Enables config reloader when host access is disabled, ensuring proper configuration updates during tests |
| admin/testadmin/testadmin.go | Adds optional runtime server support to test fixtures with dual-port allocation and proper server initialization |
| admin/jobs/river/reconcile_deployment.go | Exports worker constructor for test usage to trigger deployment reconciliation directly |
| admin/deployments_test.go | New comprehensive integration test validating deployment, environment updates, stop/restart flows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
k-anshul
force-pushed
the
admin_runtime_tests
branch
from
d1a6031 to
84a80ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/rilldata/issue/PLAT-198/add-automated-tests-for-deploy-flows
Checklist: