draft: more options in model menu item #8736
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passing connector name into second step & show name additional sourceIcons Add button to connector yaml data-sources to import data
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built off the work of Cyrus! Once #8632 lands, will merge the changes and probably have a lot of conflicting code. when ready will ask for review.
https://www.loom.com/share/fb3afd1a938e453d8235c83affccb295
This adds:
- model dropdown for existing connectors
- button to import data from connector (non-olap)
- passing the connector.name so creating correct YAML (distinct connectors of same type, gcs, gcs_1)
Checklist: