Skip to content

Fix limit and cap in the sql resolver#8790

Merged
begelundmuller merged 2 commits intomainfrom
begelundmuller/fix-sql-resolver-limit
Feb 9, 2026
Merged

Fix limit and cap in the sql resolver#8790
begelundmuller merged 2 commits intomainfrom
begelundmuller/fix-sql-resolver-limit

Conversation

@begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Feb 6, 2026

This PR fixes a bug where the sql resolver did not correctly handle the difference between:

  • the user-provided row limit (where it should stop reading and return)
  • the system-enforced row cap (where it should stop reading and error)

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller self-assigned this Feb 6, 2026
@begelundmuller begelundmuller merged commit 59c09c6 into main Feb 9, 2026
10 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/fix-sql-resolver-limit branch February 9, 2026 13:59
begelundmuller added a commit that referenced this pull request Feb 10, 2026
* Fix limit and cap in the `sql` resolver

* Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants