Merged
Conversation
begelundmuller
approved these changes
Feb 9, 2026
runtime/runtime.go
Outdated
Comment on lines
+213
to
+217
| // close the connection | ||
| r.connCache.EvictWhere(func(cfg any) bool { | ||
| x := cfg.(cachedConnectionConfig) | ||
| return x.instanceID == instanceID && x.name == name | ||
| }) |
Contributor
There was a problem hiding this comment.
What if the connector is re-opened before EditInstance is called below? Should it maybe only evict after the call to EditInstance succeeds?
begelundmuller
pushed a commit
that referenced
this pull request
Feb 10, 2026
* feat: close connections on deleting a connector in Rill * feat: close connections on deleting a connector in Rill * review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/rilldata/issue/PLAT-314/rill-does-not-release-its-lock-on-local-duckdb-databases
Checklist: