Skip to content

Fixing more test failure. #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NamanMahor merged 3 commits into from
Mar 12, 2026
Merged

Fixing more test failure. #9017

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2854940
put to gcs is failing
NamanMahor Mar 11, 2026
9b8a99d
remove debug logs
NamanMahor Mar 11, 2026
bbeb316
fix lint
NamanMahor Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions runtime/drivers/s3/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,14 @@ func getAWSConfig(ctx context.Context, confProp *ConfigProperties) (aws.Config,
opts = append(opts, config.WithRegion(confProp.Region))
}

// For GCS, we need to set the checksum validation and request calculation to required
if confProp.Endpoint != "" && strings.Contains(confProp.Endpoint, "storage.googleapis.com") {
opts = append(opts,
config.WithResponseChecksumValidation(aws.ResponseChecksumValidationWhenRequired),
config.WithRequestChecksumCalculation(aws.RequestChecksumCalculationWhenRequired),
)
}

cfg, err := config.LoadDefaultConfig(ctx, opts...)
if err != nil {
return aws.Config{}, fmt.Errorf("failed to load AWS config: %w", err)
Expand Down
Loading