Support metrics_sql in canvas transitive access resolution#9023
Merged
begelundmuller merged 3 commits intomainfrom Mar 13, 2026
Merged
Support metrics_sql in canvas transitive access resolution#9023begelundmuller merged 3 commits intomainfrom
begelundmuller merged 3 commits intomainfrom
Conversation
pjain1
reviewed
Mar 13, 2026
| } | ||
|
|
||
| // metricsSQL parses and registers metrics view references found in a metrics SQL string. | ||
| func (r *rendererRefs) metricsSQL(ctx context.Context, sql any) error { |
Member
There was a problem hiding this comment.
I don't think we parse metrics sql during reconcile, so when this is will be rendered and sql is wrong like column got deleted etc. then it will fail the entire canvas instead of just that component. Earlier I think if only a metrics view had some issue then only that component will fail.
Contributor
Author
There was a problem hiding this comment.
Great point! Yes we definitely don't want to fail the whole canvas in that case.
I updated the PR with a generic solution, does that look good?
pjain1
approved these changes
Mar 13, 2026
pjain1
approved these changes
Mar 13, 2026
begelundmuller
deleted the
begelundmuller/canvas-metrics-sql-transitive-access
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metrics_sqlproperty lookup inpopulateRendererRefs, using ametrics_sqlresolver to discover referenced metrics views viaRefs()SkipChecks: truewhen initializing the resolver to avoid infinite recursion through the security engineChecklist: