Skip to content

fix: timestamp column selection in explore not persiting#9075

Merged
AdityaHegde merged 6 commits into
mainfrom
fix/timestamp-column-not-peristing-across-refreshes
May 15, 2026
Merged

fix: timestamp column selection in explore not persiting#9075
AdityaHegde merged 6 commits into
mainfrom
fix/timestamp-column-not-peristing-across-refreshes

Conversation

@AdityaHegde
Copy link
Copy Markdown
Collaborator

@AdityaHegde AdityaHegde commented Mar 18, 2026

Timestamp column selection in explore does not persist across refreshes. This is because we were checking the selection against non-time dimensions which always failed.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde requested a review from djbarnwal May 15, 2026 04:44
@AdityaHegde AdityaHegde marked this pull request as ready for review May 15, 2026 04:44
// Get the updated url params. If we merged state other than the url we would need to navigate to it.
const redirectUrl = this.getUrlForExploreState(initExploreState);

console.log(initExploreState);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover log

@AdityaHegde AdityaHegde merged commit 1ecd398 into main May 15, 2026
9 of 10 checks passed
@AdityaHegde AdityaHegde deleted the fix/timestamp-column-not-peristing-across-refreshes branch May 15, 2026 09:25
AdityaHegde added a commit that referenced this pull request May 15, 2026
* fix: timestamp column selection in explore not persiting

* Fix tests

* Fix tests

* Fix lint
nishantmonu51 pushed a commit that referenced this pull request May 22, 2026
* fix: timestamp column selection in explore not persiting

* Fix tests

* Fix tests

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants