Conversation
|
Where will the AI button be placed if we remove this bar? Also, where is the Rill watermark? |
|
True, so we'll keep it! then need APP to approve PR @Di7design This is the Embedded, we haven't merged the Rill embed logo. this is a bug fix PR :) |
|
@AdityaHegde not sure what best practice is for missing theming. LMK if this is wrong |
AdityaHegde
left a comment
AdityaHegde
left a comment
There was a problem hiding this comment.
Yes this is how we use it outside of dashboard. Just make sure it works without issue when there is no active dashboard.
| > | ||
| <EmbedHeader {activeResource} {navigationEnabled} /> | ||
| </div> | ||
| <ThemeProvider theme={$activeDashboardTheme} applyLayout={false}> |
There was a problem hiding this comment.
What happens when there is no active dashboard?
There was a problem hiding this comment.
Is there ever an embed state without an active dashboard?
There was a problem hiding this comment.
ah, when you embed the home page; its cleared
So it's safe — when there's no active dashboard, the ThemeProvider just passes through with default/unthemed styling. Same behavior as DashboardChat.svelte which uses the same pattern.
3 participants
Are we removing this theme bar anytime soon? it doesnt get themes applied, looks weird
new: (mind the colors)
Checklist: