handle explore names with url encoding characters#9213
Merged
Conversation
begelundmuller
approved these changes
Apr 10, 2026
Comment on lines
+307
to
309
| explore := exploreNameFromAnnotations(spec.Annotations, mvName) | ||
| var canvas string | ||
| if c, ok := spec.Annotations["canvas"]; ok { |
Contributor
There was a problem hiding this comment.
Isn't the backwards compatibility here quite old? Or does these old payloads still get generated – and if so, does canvas need the same handling?
Member
Author
There was a problem hiding this comment.
Alerts still use web_open_path and does not have explore or canvas option. This was not triggered till now because probably no customer had spaces in resource name.
I do not see alert button on canvas so did not handle it, spec can still be programatically created but I think its very rate and a follow up to this PR would be to add explore/canvas options directly on AlertOptions proto like ReportOptions so we don't need to handle canvas.
Contributor
There was a problem hiding this comment.
Okay, seems fine then
pjain1
added a commit
that referenced
this pull request
Apr 10, 2026
* handle explore names with url encoding characters * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally UI should directly set explore annotation like reports so that we do not need to rely on
web_open_pathto extract explore name. But this case needs to be handled anyways for the existing alerts.Checklist: