Skip to content

fix: pivot hover description in public URL #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royendo merged 7 commits into from
Apr 20, 2026
Merged

fix: pivot hover description in public URL #9247

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d49b584
Fix pivot chip description tooltips lost on state restore
royendo Apr 15, 2026
d9a348f
Fix pivot chip description tooltips for dimensions in URL state path
royendo Apr 15, 2026
daf5dfd
Reactively enrich pivot chip descriptions from metricsView
royendo Apr 15, 2026
8290b5c
Update PivotDisplay.svelte
royendo Apr 15, 2026
9c66f76
Normalize empty pivot chip descriptions to undefined for state roundt…
royendo Apr 16, 2026
5a929fa
Address review feedback: preserve chip referential identity and pass …
royendo Apr 16, 2026
5fc0f15
Remove redundant description from deserialization mappers
royendo Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions web-common/src/features/dashboards/pivot/PivotDisplay.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import { usePivotForExplore } from "./pivot-data-store";
import PivotEmpty from "./PivotEmpty.svelte";
import PivotHeader from "./PivotHeader.svelte";
import type { PivotChipData } from "./types";
import PivotSidebar from "./PivotSidebar.svelte";
import PivotTable from "./PivotTable.svelte";
import PivotToolbar from "./PivotToolbar.svelte";
Expand All @@ -22,6 +23,7 @@
const {
exploreName,
dashboardStore,
validSpecStore,
selectors: {
pivot: { columns, measures, dimensions },
},
Expand Down Expand Up @@ -55,6 +57,32 @@

$: ({ isFetching, assembled } = $pivotDataStore);

// Build a description lookup from the metricsView so pivot chips get
// descriptions even when the metricsView loads after the pivot state
// is deserialized (e.g. public URL first load).
$: descriptionMap = new Map<string, string | undefined>([
...($validSpecStore.data?.metricsView?.dimensions ?? []).map(
(d) => [d.name, d.description] as [string, string | undefined],
),
...($validSpecStore.data?.metricsView?.measures ?? []).map(
(m) => [m.name, m.description] as [string, string | undefined],
),
]);

function enrichDescriptions(chips: PivotChipData[]): PivotChipData[] {
return chips.map((chip) => {
if (chip.description) return chip;
const desc = descriptionMap.get(chip.id);
return desc ? { ...chip, description: desc } : chip;
});
}

$: enrichedPivotState = {
...$dashboardStore.pivot,
rows: enrichDescriptions($dashboardStore.pivot.rows),
columns: enrichDescriptions($dashboardStore.pivot.columns),
};

$: hasColumnAndNoMeasure =
$columns.dimension.length > 0 && $columns.measure.length === 0;

Expand All @@ -67,7 +95,7 @@
<div class="layout" class:h-full={!$dynamicHeight}>
{#if showPanels}
<PivotSidebar
pivotState={$dashboardStore.pivot}
pivotState={enrichedPivotState}
measures={$measures}
dimensions={$dimensions}
{timeControlsForPillActions}
Expand All @@ -80,7 +108,7 @@
>
{#if showPanels}
<PivotHeader
pivotState={$dashboardStore.pivot}
pivotState={enrichedPivotState}
setRows={(rows) =>
metricsExplorerStore.setPivotRows($exploreName, rows)}
setColumns={(columns) =>
Expand All @@ -96,7 +124,7 @@
}}
>
<PivotToolbar
pivotState={$dashboardStore.pivot}
pivotState={enrichedPivotState}
setTableMode={(tableMode, rows, columns) =>
metricsExplorerStore.setPivotTableMode(
$exploreName,
Expand Down
Loading