Skip to content

fix: metrics view model dropdown#9254

Merged
royendo merged 3 commits into
mainfrom
worktree-fix-metrics-view-model-dropdown
Apr 20, 2026
Merged

fix: metrics view model dropdown#9254
royendo merged 3 commits into
mainfrom
worktree-fix-metrics-view-model-dropdown

Conversation

@royendo
Copy link
Copy Markdown
Contributor

@royendo royendo commented Apr 16, 2026

Fix missing olap for MotherDuck,
Fix populate table in visual editor properly

Add: open the current metrics view but have the others available but not opened

Screenshot 2026-04-16 at 12 57 02

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

royendo and others added 2 commits April 16, 2026 12:46
- When a metrics view YAML declares `connector:`, show the data explorer dropdown filtered to that connector (e.g. CH-only or MD-only).
- On projects with no models/sources, fall back to the data explorer dropdown instead of an empty "no results found" model picker.
- Plumb `filterConnector` prop through `ConnectorExplorer` for per-connector filtering.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…its default database/schema

The backend skips writing `database:` and `database_schema:` when the connector is at its defaults, but the UI required an exact match, so the dropdown showed "Select table" instead of the actual table name.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@royendo royendo requested a review from AdityaHegde April 16, 2026 17:52
@AdityaHegde
Copy link
Copy Markdown
Collaborator

Wont this block updating model to other connectors? We should probably allow updating to anything, but update fields like connector when they are selected.

@royendo
Copy link
Copy Markdown
Contributor Author

royendo commented Apr 17, 2026

I personally dont think we should support swapping a Duck -> CH or CH -> MD metrics view; (the blank metrics view option is kind of confusing as it starts in an errored state)

Since we do have that option today you can list all connectors but once you select; makes sense to me to be locked down. @ericokuma thoughts?

If we dont agree, i can strip out that part of the logic as MD is broken today and needs to be fixed

@royendo
Copy link
Copy Markdown
Contributor Author

royendo commented Apr 17, 2026

I went ahead and removed the filterConnector logic and replaced with defaultExpand, basically visually taking the user to the connector that is currently being used.

Im still a bit against it but i also realize a misclick of connector would lock them out;

@royendo
Copy link
Copy Markdown
Contributor Author

royendo commented Apr 17, 2026

https://www.loom.com/share/5d2823e3cdd544faae84c690a4c23c42?from_recorder=1&focus_title=1

on another hand, do we even need model selector in the UI if the table lists all and metrics view already has all OLAP in the dropdown 🤔

Copy link
Copy Markdown
Contributor

If we don't show model selector, then why create a model?

Copy link
Copy Markdown
Contributor

Also, this still doesn't solve for: "the blank metrics view option is kind of confusing as it starts in an errored state"

@royendo
Copy link
Copy Markdown
Contributor Author

royendo commented Apr 18, 2026

If we don't show model selector, then why create a model?

Rill model = duckdb table/view; the PR screenshot shows duckdb as one of the selectable OLAP,

Not for this PR but just an idea as I was poking around

@royendo
Copy link
Copy Markdown
Contributor Author

royendo commented Apr 18, 2026

Also, this still doesn't solve for: "the blank metrics view option is kind of confusing as it starts in an errored state"

This is also out of scope, simple fix is remove blank metrics view from the UI.

Don't see a real reason to keep this path now that Aditya added selectable metrics based on connector

@royendo royendo merged commit 9145a7e into main Apr 20, 2026
11 checks passed
@royendo royendo deleted the worktree-fix-metrics-view-model-dropdown branch April 20, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants