fix: bq table in metrics view UI not loading;#9282
Merged
Conversation
…st hang For a metrics view with an explicit connector/database/database_schema/table, the visual editor was blocking the table display on OLAPListTables, which walks every dataset in BigQuery and rarely completes. The editor now trusts the YAML fields directly in that case, and hides the 'Select model' mode switch since live-connector views never select a Rill model. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Icon resolves via the existing `connector` fallback chain, so when the YAML has no connector set, it defaults to the project's OLAP connector. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…able Adds a leadingIcon prop to Select/Input so the visual metrics editor can show the project OLAP icon inside the Model dropdown. The table-side icon is restored to show only once a table is selected. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
royendo
changed the title
AdityaHegde
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add additional logo in table UI for easy indication what the table is for:
Switch to model button wasn't working so hidden when connector/table is selected; again not sure we really need it but wont strip code out for now;
when creating a new blank metrics; still defaults to model selector using default OLAP is Duck; else defaults to Table
Checklist: